Conversation
Used fmt instead of string concatenation Fixed a few typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings!
Thank you for contributing to this project!
If this is your first time contributing to this project, please make
sure to read the CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be no description in your Pull Request.Please add an understanding of what this change proposes to do and why it is needed
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 87.93% 80.85% -7.08%
==========================================
Files 8 9 +1
Lines 315 350 +35
==========================================
+ Hits 277 283 +6
- Misses 25 53 +28
- Partials 13 14 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey mate, thanks for the PR!
Left some comments, would u mind taking a look?
Also, I think it would be nice to have a couple of tests before merging this. You may take a look at how the other backends are implementing.
Great with Azure Key Vault support.. but it really needs managed identity support (using aad-pod-identity). |
Thanks for the suggestion @tesharp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the chance to test this today. Awesome stuff! Approving it now :)
Azure Key Vault now available!
Closes #128