Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Azure backend #141

Merged
merged 8 commits into from Dec 30, 2020
Merged

Azure backend #141

merged 8 commits into from Dec 30, 2020

Conversation

sebagomez
Copy link
Contributor

@sebagomez sebagomez commented Nov 25, 2020

Azure Key Vault now available!

Closes #128

Copy link
Contributor

@paul-the-alien paul-the-alien bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings!
Thank you for contributing to this project!
If this is your first time contributing to this project, please make
sure to read the CONTRIBUTING.md

@paul-the-alien paul-the-alien bot closed this Nov 25, 2020
Copy link
Contributor

@paul-the-alien paul-the-alien bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be no description in your Pull Request.Please add an understanding of what this change proposes to do and why it is needed

@sebagomez sebagomez reopened this Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #141 (3b97575) into master (28fcb8e) will decrease coverage by 7.07%.
The diff coverage is 17.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   87.93%   80.85%   -7.08%     
==========================================
  Files           8        9       +1     
  Lines         315      350      +35     
==========================================
+ Hits          277      283       +6     
- Misses         25       53      +28     
- Partials       13       14       +1     
Impacted Files Coverage Δ
pkg/akv/backend.go 17.14% <17.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fcb8e...cba821c. Read the comment docs.

Copy link
Contributor

@jonatasbaldin jonatasbaldin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey mate, thanks for the PR!

Left some comments, would u mind taking a look?

Also, I think it would be nice to have a couple of tests before merging this. You may take a look at how the other backends are implementing.

docs/backends/akv.md Outdated Show resolved Hide resolved
pkg/akv/backend.go Outdated Show resolved Hide resolved
pkg/akv/backend.go Outdated Show resolved Hide resolved
@tesharp
Copy link

tesharp commented Dec 9, 2020

Great with Azure Key Vault support.. but it really needs managed identity support (using aad-pod-identity).

@sebagomez
Copy link
Contributor Author

Thanks for the suggestion @tesharp
The External Secret Operator could be running anywhere, and it will get your secrets from the different resources (backends). It does make sense though, that if you have your secrets in Azure Key Vault and your cluster running on Azure Kubernetes Services, you will want to use a managed identity. I'll take a look at it.

Copy link
Contributor

@knelasevero knelasevero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the chance to test this today. Awesome stuff! Approving it now :)

@sebagomez sebagomez merged commit 943f9d9 into master Dec 30, 2020
@paul-the-alien paul-the-alien bot deleted the azure-backend branch December 30, 2020 14:36
amouat pushed a commit that referenced this pull request May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support azure Key Vault as an backend
5 participants